Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔥 drop Python 3.8 support #454

Merged
merged 2 commits into from
Sep 6, 2024
Merged

🔥 drop Python 3.8 support #454

merged 2 commits into from
Sep 6, 2024

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Sep 5, 2024

Description

Python 3.8 will reach end of live in October 2024.
Qiskit is already issuing deprecation warnings since a couple of releases when using it on Python 3.8.
This PR officially drops support for Python 3.8 in mqt-qcec.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this Sep 5, 2024
@burgholzer burgholzer added dependencies Pull requests that update a dependency file python Anything related to Python code labels Sep 5, 2024
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer enabled auto-merge (squash) September 6, 2024 22:25
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.2%. Comparing base (4fbe57c) to head (05c000e).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #454     +/-   ##
=======================================
- Coverage   95.3%   95.2%   -0.1%     
=======================================
  Files         40      40             
  Lines       1836    1837      +1     
  Branches     224     224             
=======================================
  Hits        1750    1750             
- Misses        86      87      +1     
Flag Coverage Δ
cpp 95.6% <ø> (-0.1%) ⬇️
python 93.7% <ø> (ø)

see 2 files with indirect coverage changes

@burgholzer burgholzer merged commit 3628c33 into main Sep 6, 2024
33 checks passed
@burgholzer burgholzer deleted the drop-python-38-support branch September 6, 2024 23:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant