Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

➖ only require typing_extensions on Python < 3.11 #445

Merged
merged 1 commit into from
Aug 14, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR removes the typing_extensions dependency for Python >= 3.11 and adds a compatibility typing module to abstract away the difference across Python versions.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added dependencies Pull requests that update a dependency file python Anything related to Python code enhancement Anything related to improvements of the existing library labels Aug 14, 2024
@burgholzer burgholzer self-assigned this Aug 14, 2024
@burgholzer burgholzer enabled auto-merge (squash) August 14, 2024 13:28
@burgholzer burgholzer merged commit c634603 into main Aug 14, 2024
24 checks passed
@burgholzer burgholzer deleted the typing-extensions branch August 14, 2024 13:42
Copy link

codecov bot commented Nov 12, 2024

Codecov Report

Attention: Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.

Project coverage is 95.4%. Comparing base (1ae653b) to head (b30b25a).
Report is 81 commits behind head on main.

Files with missing lines Patch % Lines
src/mqt/qcec/_compat/typing.py 0.0% 8 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #445     +/-   ##
=======================================
- Coverage   95.8%   95.4%   -0.5%     
=======================================
  Files         39      40      +1     
  Lines       1831    1839      +8     
  Branches     224     224             
=======================================
  Hits        1755    1755             
- Misses        76      84      +8     
Flag Coverage Δ *Carryforward flag
cpp 95.8% <ø> (ø) Carriedforward from 1ae653b
python 94.0% <0.0%> (-1.9%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
src/mqt/qcec/verify.py 100.0% <ø> (ø)
src/mqt/qcec/verify_compilation_flow.py 100.0% <ø> (ø)
src/mqt/qcec/_compat/typing.py 0.0% <0.0%> (ø)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file enhancement Anything related to improvements of the existing library python Anything related to Python code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant