Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Switch to mqt-core Python package #432

Draft
wants to merge 8 commits into
base: main
Choose a base branch
from
Draft

Conversation

burgholzer
Copy link
Member

Description

This is an alternative to #355 and hopefully marks the final try of directly incorporating the mqt-core Python package. See #355 and #352 for some history on this topic.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added feature New feature or request dependencies Pull requests that update a dependency file python Anything related to Python code packaging Anything related to Python packaging c++ Anything related to C++ code minor Part of a minor release labels Aug 6, 2024
@burgholzer burgholzer self-assigned this Aug 6, 2024
Copy link

codecov bot commented Aug 6, 2024

Codecov Report

Attention: Patch coverage is 95.50562% with 4 lines in your changes missing coverage. Please review.

Project coverage is 95.1%. Comparing base (69c6156) to head (fcb3755).

Files with missing lines Patch % Lines
src/mqt/qcec/__init__.py 88.8% 2 Missing ⚠️
src/mqt/qcec/parameterized.py 96.8% 2 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #432     +/-   ##
=======================================
- Coverage   95.3%   95.1%   -0.2%     
=======================================
  Files         40      40             
  Lines       1837    1847     +10     
  Branches     224     224             
=======================================
+ Hits        1751    1758      +7     
- Misses        86      89      +3     
Flag Coverage Δ
cpp 95.6% <ø> (-0.1%) ⬇️
python 93.4% <95.5%> (-0.4%) ⬇️
Files with missing lines Coverage Δ
src/mqt/qcec/verify.py 100.0% <100.0%> (ø)
src/mqt/qcec/verify_compilation_flow.py 100.0% <ø> (ø)
src/mqt/qcec/__init__.py 91.3% <88.8%> (-8.7%) ⬇️
src/mqt/qcec/parameterized.py 94.5% <96.8%> (-0.4%) ⬇️

... and 1 file with indirect coverage changes

@burgholzer burgholzer force-pushed the use-mqt-core-package branch 6 times, most recently from 96ff41e to db6cb20 Compare August 10, 2024 13:34
@burgholzer burgholzer force-pushed the use-mqt-core-package branch 5 times, most recently from 055c342 to bf94b85 Compare August 14, 2024 17:25
@burgholzer burgholzer force-pushed the use-mqt-core-package branch 2 times, most recently from 77145ad to 64dfa87 Compare September 4, 2024 21:26
@burgholzer burgholzer added major Part of a major release and removed minor Part of a minor release labels Sep 4, 2024
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
(temporarily as a git dependency)

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code dependencies Pull requests that update a dependency file feature New feature or request major Part of a major release packaging Anything related to Python packaging python Anything related to Python code
Projects
Status: In Progress
Status: In Progress
Development

Successfully merging this pull request may close these issues.

1 participant