Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚨 Fix new warnings revealed by clang-tidy 18 #401

Merged
merged 3 commits into from
Jun 21, 2024

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented May 29, 2024

Description

This PR aims to fix all the new warnings that were introduced in clang-tidy versions 18, which have been enabled with the switch to the mqt-workflows@v1.0.0.

The first commit, which will later be reverted, just triggers a full clang-tidy run on the whole codebase.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer self-assigned this May 29, 2024
.github/workflows/ci.yml Outdated Show resolved Hide resolved
@burgholzer burgholzer added good first issue Good for newcomers help wanted Extra attention is needed labels Jun 20, 2024
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer force-pushed the fix-clang-tidy-17-18-warnings branch from 8bc2151 to 1159560 Compare June 20, 2024 18:45
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.6%. Comparing base (015d0e6) to head (9d0da4e).
Report is 53 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #401     +/-   ##
=======================================
+ Coverage   96.3%   96.6%   +0.3%     
=======================================
  Files         35      35             
  Lines       1818    1817      -1     
  Branches     224     224             
=======================================
+ Hits        1751    1757      +6     
+ Misses        67      60      -7     
Flag Coverage Δ
cpp 96.5% <100.0%> (+0.4%) ⬆️
python 97.2% <ø> (ø)
Files with missing lines Coverage Δ
include/Configuration.hpp 0.0% <ø> (ø)
include/EquivalenceCheckingManager.hpp 100.0% <100.0%> (ø)
include/EquivalenceCriterion.hpp 88.8% <ø> (ø)
include/ThreadSafeQueue.hpp 95.0% <100.0%> (ø)
include/checker/EquivalenceChecker.hpp 100.0% <ø> (ø)
include/checker/dd/DDAlternatingChecker.hpp 100.0% <ø> (ø)
include/checker/dd/DDConstructionChecker.hpp 83.3% <ø> (ø)
include/checker/dd/DDEquivalenceChecker.hpp 100.0% <ø> (ø)
include/checker/dd/DDSimulationChecker.hpp 100.0% <ø> (ø)
include/checker/dd/TaskManager.hpp 98.5% <100.0%> (ø)
... and 18 more

@burgholzer burgholzer force-pushed the fix-clang-tidy-17-18-warnings branch 2 times, most recently from 776c17b to a8d5df9 Compare June 21, 2024 11:02
@burgholzer burgholzer added the code quality Anything related to code quality and code style. label Jun 21, 2024
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer force-pushed the fix-clang-tidy-17-18-warnings branch from a8d5df9 to c465f2a Compare June 21, 2024 13:48
@burgholzer burgholzer enabled auto-merge (squash) June 21, 2024 16:04
@burgholzer burgholzer merged commit 104a25c into main Jun 21, 2024
34 checks passed
@burgholzer burgholzer deleted the fix-clang-tidy-17-18-warnings branch June 21, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Anything related to code quality and code style. good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant