🧱 switch to dedicated reusable MQT workflows #396
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
burgholzer
added
dependencies
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #396 +/- ##
=======================================
- Coverage 96.6% 96.4% -0.3%
=======================================
Files 35 35
Lines 1818 1819 +1
Branches 224 225 +1
=======================================
- Hits 1758 1755 -3
- Misses 60 64 +4
|
4 tasks
|
The macOS related failures seen here should be resolved by cda-tum/mqt-core#608 |
burgholzer
added a commit
to cda-tum/mqt-core
that referenced
this pull request
May 23, 2024
## Description This PR changes the CMake configuration so that GMP, which can be used in the ZX library, needs to be explicitly added (opt-in) instead of automatically being used (actually unconditionally, without an opt-out option). This has popped up in cda-tum/mqt-qcec#396 since `delocate` fails to properly repair the produced wheel. This is a result of `gmp` being automatically installed on macOS runners via brew. However, this gets the latest system version, which is not compatible with the minimum macOS targets that we set. I believe this only popped up now, because there has been a `delocate` update that catches this. In lack of a better option at the moment, this PR makes GMP support entirely opt-in, which disables it for wheel builds and resolves the underlying issue. Anyone that wants to build MQT Core with GMP support, can now configure CMake with `-DMQT_CORE_WITH_GMP` In the future, it might be worth investigating whether there is a better way to do this, e.g., by manually building `gmp` with the required compatibility. ## Checklist: <!--- This checklist serves as a reminder of a couple of things that ensure your pull request will be merged swiftly. --> - [x] The pull request only contains commits that are related to it. - [x] I have added appropriate tests and documentation. - [x] I have made sure that all CI jobs on GitHub pass. - [x] The pull request introduces no new warnings and follows the project's style guidelines. Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR switches the reusable workflows from MQT Core to the ones hosted at https://github.com/cda-tum/mqt-workflows. This creates a better separation of concerns and allows for separate versioning of the workflows and the MQT Core library.
Furthermore, this PR adapts the configuration of the continuous deployment job so that the job is also triggered if the respective workflow file is updated. This should help to catch errors as early as possible when dependabot updates the workflow.
Checklist: