Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️🩹 Update mqt-core with a fix for ancillary qubit handling #340

Merged
merged 2 commits into from
Dec 12, 2023

Conversation

burgholzer
Copy link
Member

Description

This PR updates mqt-core with a new fix (cda-tum/mqt-core#495) for a small bug that resulted in two circuits that were acting on the same number of "primary" qubits to report that circuits differed in their number of qubits.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer added dependencies Pull requests that update a dependency file submodules Pull requests that update Submodules code c++ Anything related to C++ code fix Anything related to bugfixes labels Dec 12, 2023
@burgholzer burgholzer self-assigned this Dec 12, 2023
Copy link

codecov bot commented Dec 12, 2023

Codecov Report

Merging #340 (3b17c3a) into main (c56dde4) will decrease coverage by 0.2%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #340     +/-   ##
=======================================
- Coverage   96.3%   96.2%   -0.2%     
=======================================
  Files         34      34             
  Lines       1739    1738      -1     
  Branches     213     212      -1     
=======================================
- Hits        1676    1672      -4     
- Misses        63      66      +3     
Flag Coverage Δ
cpp 95.9% <ø> (-0.3%) ⬇️
python 97.2% <ø> (ø)

see 2 files with indirect coverage changes

Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer enabled auto-merge (squash) December 12, 2023 13:23
@burgholzer burgholzer merged commit 854a96a into main Dec 12, 2023
34 checks passed
@burgholzer burgholzer deleted the update-mqt-core branch December 12, 2023 13:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code dependencies Pull requests that update a dependency file fix Anything related to bugfixes submodules Pull requests that update Submodules code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant