Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ CI/CD Update #220

Merged
merged 50 commits into from
May 2, 2024
Merged

✨ CI/CD Update #220

merged 50 commits into from
May 2, 2024

Conversation

nquetschlich
Copy link
Collaborator

@nquetschlich nquetschlich commented Apr 24, 2024

This PR

  • improves the CI/CD workflows
  • implements multiple small improvements revealed by the more comprehensive tests

@nquetschlich nquetschlich added enhancement New feature or request continuous integration Anything related to the CI setup labels Apr 24, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.7%. Comparing base (e8ba13d) to head (8e97d58).

Additional details and impacted files
@@           Coverage Diff           @@
##            main    #220     +/-   ##
=======================================
+ Coverage   79.5%   79.7%   +0.1%     
=======================================
  Files         12      12             
  Lines        965     967      +2     
=======================================
+ Hits         768     771      +3     
+ Misses       197     196      -1     
Flag Coverage Δ
python 79.7% <100.0%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@nquetschlich
Copy link
Collaborator Author

@burgholzer Although all tests are green, the warning handling currently is a bit too generic because I had problems figuring out where exactly the warnings appeared to exclude them more specifically.

@nquetschlich
Copy link
Collaborator Author

Reminder: Before merging, MQT Bench needs a new release and we need to update the dependency here accordingly.

Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This mostly looks good. Many thanks 🙏 just a couple of rather minor comments that should be easy to address.

README.md Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
pyproject.toml Outdated Show resolved Hide resolved
tests/test_pretrained_models.py Outdated Show resolved Hide resolved
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼
Do you really want to have the mqt-bench dependency in like that or wait for the new mqt-bench release?

@nquetschlich nquetschlich merged commit ae7d667 into main May 2, 2024
20 checks passed
@nquetschlich nquetschlich deleted the update_cicd branch May 2, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Anything related to the CI setup enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants