Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🚸 Small library improvements #430

Merged
merged 5 commits into from
Sep 6, 2024
Merged

🚸 Small library improvements #430

merged 5 commits into from
Sep 6, 2024

Conversation

burgholzer
Copy link
Member

Description

This PR contains a couple of assorted library improvements including touch ups on the CMake config, the mypy configuration, and the pre-commit hooks.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this Sep 6, 2024
@burgholzer burgholzer added dependencies Pull requests that update a dependency file code quality Anything related to code quality and code style. usability Anything related to usability labels Sep 6, 2024
Copy link

codecov bot commented Sep 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.3%. Comparing base (fc07083) to head (46eff60).
Report is 59 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #430     +/-   ##
=======================================
- Coverage   92.5%   92.3%   -0.2%     
=======================================
  Files         37      37             
  Lines       2721    2720      -1     
  Branches     305     304      -1     
=======================================
- Hits        2517    2512      -5     
- Misses       204     208      +4     
Flag Coverage Δ
cpp 94.1% <ø> (-0.3%) ⬇️
python 87.4% <ø> (ø)

see 2 files with indirect coverage changes

@burgholzer burgholzer enabled auto-merge September 6, 2024 20:30
@burgholzer burgholzer merged commit 4409d5d into main Sep 6, 2024
34 checks passed
@burgholzer burgholzer deleted the small-improvements branch September 6, 2024 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
code quality Anything related to code quality and code style. dependencies Pull requests that update a dependency file usability Anything related to usability
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant