Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⚡🔧 Faster cibuildwheel and better Windows wheel repair #386

Merged
merged 5 commits into from
Jun 21, 2024

Conversation

burgholzer
Copy link
Member

@burgholzer burgholzer commented Jun 17, 2024

Description

This PR makes use of cibuildwheel's latest addition of a build[uv] build frontend option that uses uv under the hood to speed up the build process.
Furthermore, it adjusts the Windows repair command to respect namespace packages.

Before: 11h 23m 43s, After: 10h 59m 31s

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer self-assigned this Jun 17, 2024
@burgholzer burgholzer added dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code continuous integration Anything related to the CI setup labels Jun 17, 2024
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer enabled auto-merge (squash) June 20, 2024 14:35
Copy link

codecov bot commented Jun 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.6%. Comparing base (1a3ead5) to head (68d386f).
Report is 64 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##            main    #386     +/-   ##
=======================================
+ Coverage   92.5%   92.6%   +0.1%     
=======================================
  Files         37      37             
  Lines       2561    2561             
  Branches     309     310      +1     
=======================================
+ Hits        2370    2374      +4     
+ Misses       191     187      -4     
Flag Coverage Δ
cpp 94.8% <ø> (+0.2%) ⬆️
python 87.3% <ø> (ø)

see 2 files with indirect coverage changes

@burgholzer burgholzer disabled auto-merge June 20, 2024 15:37
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer burgholzer merged commit c9fcb81 into main Jun 21, 2024
57 checks passed
@burgholzer burgholzer deleted the update-mqt-workflows branch June 21, 2024 08:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Anything related to the CI setup dependencies Pull requests that update a dependency file github_actions Pull requests that update GitHub Actions code
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant