Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🐛 fix missing mcx gate support in OpenQASM3 parser #526

Merged
merged 1 commit into from
Jan 8, 2024

Conversation

burgholzer
Copy link
Member

Description

This fixes a small regression in the new QASM parser where plain mcx statements were no longer accepted.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@burgholzer burgholzer added fix Fix for something that isn't working Core Anything related to the Core library and IR c++ Anything related to C++ code labels Jan 8, 2024
@burgholzer burgholzer added this to the OpenQASM 3.0 Support milestone Jan 8, 2024
@burgholzer burgholzer self-assigned this Jan 8, 2024
@burgholzer burgholzer enabled auto-merge (squash) January 8, 2024 08:49
Copy link

codecov bot commented Jan 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ba9ba16) 91.3% compared to head (cb0daf3) 91.3%.

Additional details and impacted files

Impacted file tree graph

@@          Coverage Diff          @@
##            main    #526   +/-   ##
=====================================
  Coverage   91.3%   91.3%           
=====================================
  Files        128     128           
  Lines      13794   13795    +1     
  Branches    2149    2149           
=====================================
+ Hits       12601   12602    +1     
  Misses      1193    1193           
Flag Coverage Δ
cpp 91.0% <100.0%> (+<0.1%) ⬆️
python 99.7% <ø> (ø)
Files Coverage Δ
src/parsers/QASM3Parser.cpp 90.5% <100.0%> (+<0.1%) ⬆️

@burgholzer burgholzer merged commit e78165b into main Jan 8, 2024
34 checks passed
@burgholzer burgholzer deleted the fix-mcx-oq3-regression branch January 8, 2024 09:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c++ Anything related to C++ code Core Anything related to the Core library and IR fix Fix for something that isn't working
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

1 participant