Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ improve CI/CD and package itself #322

Merged
merged 69 commits into from
Apr 24, 2024
Merged

Conversation

nquetschlich
Copy link
Collaborator

@nquetschlich nquetschlich commented Apr 21, 2024

This PR

  • improves the CI/CD workflows
  • improves the mqt.bench package structure by moving mqt.benchviewer into mqt.bench.viewer
  • implements multiple small improvements revealed by the more comprehensive tests

@nquetschlich nquetschlich added enhancement New feature or request continuous integration Anything related to the CI setup labels Apr 21, 2024
@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

Copy link

codecov bot commented Apr 21, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 93.0%. Comparing base (0aaca11) to head (aa0d884).

Files Patch % Lines
src/mqt/bench/benchmark_generator.py 0.0% 1 Missing ⚠️
src/mqt/bench/utils.py 66.6% 1 Missing ⚠️
src/mqt/bench/viewer/main.py 66.6% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #322     +/-   ##
=======================================
+ Coverage   91.8%   93.0%   +1.1%     
=======================================
  Files         47      47             
  Lines       2441    2437      -4     
=======================================
+ Hits        2243    2268     +25     
+ Misses       198     169     -29     
Flag Coverage Δ
python 93.0% <83.3%> (?)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

nquetschlich and others added 24 commits April 21, 2024 15:50
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
(which we have no control over)

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@nquetschlich nquetschlich changed the title ✨ improve CI/CD workflows ✨ improve CI/CD and package itsel Apr 24, 2024
@nquetschlich nquetschlich changed the title ✨ improve CI/CD and package itsel ✨ improve CI/CD and package itself Apr 24, 2024
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good 👍🏻 I think this is another nice improvement to the library and its usability.

README.md Outdated Show resolved Hide resolved
@nquetschlich nquetschlich merged commit e1772c3 into main Apr 24, 2024
19 of 20 checks passed
@nquetschlich nquetschlich deleted the add_reusable_workflows branch April 24, 2024 20:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
continuous integration Anything related to the CI setup enhancement New feature or request
Projects
Status: Done
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants