Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve ruff config #315

Merged
merged 12 commits into from
Apr 10, 2024
Merged

Improve ruff config #315

merged 12 commits into from
Apr 10, 2024

Conversation

nquetschlich
Copy link
Collaborator

I added more ruff checks using https://github.com/cda-tum/mqt-qcec/blob/main/pyproject.toml as a template.

@nquetschlich nquetschlich added the enhancement New feature or request label Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

Attention: Patch coverage is 98.76543% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 91.8%. Comparing base (b430673) to head (e78fbac).

Files Patch % Lines
src/mqt/bench/benchmarks/ae.py 50.0% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #315     +/-   ##
=======================================
- Coverage   91.9%   91.8%   -0.1%     
=======================================
  Files         46      46             
  Lines       2416    2419      +3     
=======================================
+ Hits        2221    2223      +2     
- Misses       195     196      +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
Signed-off-by: burgholzer <burgholzer@me.com>
@burgholzer
Copy link
Member

I took the liberty of updating a little more of the overall ruff/pre-commit configuration.
MQT Bench now also complies with all the guidelines of the Scientific Python Guide from https://learn.scientific-python.org/development/guides/repo-review/.
I will take care of getting the CI green.

Signed-off-by: burgholzer <burgholzer@me.com>
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Would be nice if these changes would also make it to the other repositories!

@nquetschlich nquetschlich merged commit 6c2d381 into main Apr 10, 2024
15 checks passed
@nquetschlich nquetschlich deleted the improve_ruff_config branch April 10, 2024 07:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants