Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MQTPredictor update #299

Merged
merged 23 commits into from
Feb 26, 2024
Merged

MQTPredictor update #299

merged 23 commits into from
Feb 26, 2024

Conversation

flowerthrower
Copy link
Collaborator

Mostly bug fixes that became clear when trying to update MQTPredictor based on the new device class.

Copy link

codecov bot commented Feb 8, 2024

Codecov Report

Attention: Patch coverage is 95.55556% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 91.9%. Comparing base (8f2db01) to head (9dc6b0c).

Files Patch % Lines
src/mqt/bench/utils.py 66.6% 2 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##            main    #299     +/-   ##
=======================================
- Coverage   93.2%   91.9%   -1.3%     
=======================================
  Files         46      46             
  Lines       2407    2427     +20     
=======================================
- Hits        2244    2232     -12     
- Misses       163     195     +32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@flowerthrower flowerthrower marked this pull request as draft February 19, 2024 12:45
@flowerthrower flowerthrower marked this pull request as ready for review February 19, 2024 13:24
Copy link
Collaborator

@nquetschlich nquetschlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for those changes. I just have a few questions to better understand them.

Additionally, I have one larger comment that probably requires a moderate effort: We should substitute the M3 for the M2 instead of keeping both devices. This means, that all files must be clear of the M2 device including the configuration file.

For the benchviewer, we currently stick to the M2 device and, therefore, those files must not be adjusted. The rationale is, that we will soon update to Qiskit v1.0.0 and then re-create all benchmark files and do not want to do it now additionally since it comes with a significant effort.

src/mqt/bench/devices/rigetti.py Outdated Show resolved Hide resolved
src/mqt/bench/devices/rigetti.py Outdated Show resolved Hide resolved
src/mqt/bench/devices/rigetti.py Show resolved Hide resolved
tests/devices/test_rigetti_device_support.py Outdated Show resolved Hide resolved
@nquetschlich
Copy link
Collaborator

resolves #279

Copy link
Collaborator

@nquetschlich nquetschlich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As soon as the code comments are clarified and the currently failing test is fixed, this PR is ready to be merged.

tests/test_bench.py Outdated Show resolved Hide resolved
tests/test_benchviewer.py Outdated Show resolved Hide resolved
tests/test_benchviewer.py Outdated Show resolved Hide resolved
tests/test_benchviewer.py Outdated Show resolved Hide resolved
@nquetschlich nquetschlich merged commit 379bc9c into main Feb 26, 2024
14 of 15 checks passed
@nquetschlich nquetschlich deleted the predictor_update branch February 26, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants