Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

🎨 Improved SupermarQ feature calculation #298

Merged
merged 7 commits into from
Feb 7, 2024
Merged

🎨 Improved SupermarQ feature calculation #298

merged 7 commits into from
Feb 7, 2024

Conversation

nquetschlich
Copy link
Collaborator

I compared our implementation of the SupermarQ feature calculation with their implementation and copied their code for liveness and program_communication because it seemed better to me in terms of understadability.

@nquetschlich
🎨 compared supermarq feature calculation to original paper implementa…
4a9949d 
…tion and copied/improved for two out of five features
@nquetschlich nquetschlich added the enhancement New feature or request label Feb 6, 2024
@codecov Codecov
Copy link

codecov bot commented Feb 6, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ad33f01) 93.6% compared to head (e6ca4d2) 93.3%.

Additional details and impacted files 
@@           Coverage Diff           @@
##            main    #298     +/-   ##
=======================================
- Coverage   93.6%   93.3%   -0.3%     
=======================================
  Files         46      46             
  Lines       2416    2405     -11     
=======================================
- Hits        2262    2245     -17     
- Misses       154     160      +6

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

burgholzer
burgholzer requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I really like the changes here! Makes the code quite a bit cleaner.
I believe this can be taken one step further though as indicated in the inline comments.

src/mqt/bench/utils.py Outdated Show resolved Hide resolved
src/mqt/bench/utils.py Outdated Show resolved Hide resolved
src/mqt/bench/utils.py Outdated Show resolved Hide resolved
burgholzer
burgholzer requested changes Feb 6, 2024
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks for the changes. Looking really good already. I just have one suggestion for the code itself and one for the tests.

src/mqt/bench/utils.py Outdated Show resolved Hide resolved
tests/test_bench.py Outdated Show resolved Hide resolved
burgholzer
burgholzer approved these changes Feb 7, 2024
View reviewed changes
Copy link
Member

@burgholzer burgholzer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great. Thanks for all the extra effort. 🎉

@nquetschlich nquetschlich merged commit 7839365 into main Feb 7, 2024
15 checks passed
@nquetschlich nquetschlich deleted the improved_supermarq_calculation branch February 7, 2024 10:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@burgholzer burgholzer burgholzer approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nquetschlich @burgholzer