Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔧 Attempt to calm down clang-tidy #522

Merged
merged 6 commits into from
Sep 6, 2024
Merged

🔧 Attempt to calm down clang-tidy #522

merged 6 commits into from
Sep 6, 2024

Conversation

marcelwa
Copy link
Collaborator

@marcelwa marcelwa commented Sep 5, 2024

Description

Silence a few redundant warnings by clang-tidy.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@marcelwa marcelwa added the github_actions Pull requests that update GitHub Actions code label Sep 5, 2024
@marcelwa marcelwa self-assigned this Sep 5, 2024
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.15%. Comparing base (523cf23) to head (71ec34d).
Report is 1 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff           @@
##             main     #522   +/-   ##
=======================================
  Coverage   98.14%   98.15%           
=======================================
  Files         224      224           
  Lines       31304    31298    -6     
  Branches     1563     1563           
=======================================
- Hits        30724    30721    -3     
+ Misses        580      577    -3     

see 3 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 523cf23...71ec34d. Read the comment docs.

Copy link
Contributor

github-actions bot commented Sep 5, 2024

clang-tidy review says "All clean, LGTM! 👍"

Copy link
Contributor

github-actions bot commented Sep 6, 2024

clang-tidy review says "All clean, LGTM! 👍"

@marcelwa marcelwa merged commit 1547f0c into main Sep 6, 2024
61 checks passed
@marcelwa marcelwa deleted the calm-down-clang-tidy branch September 6, 2024 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
github_actions Pull requests that update GitHub Actions code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant