Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

✨ Extended BDL input iterator to support different SiDB input representations #521

Conversation

Drewniok
Copy link
Collaborator

@Drewniok Drewniok commented Sep 3, 2024

Description

This PR extends the BDL input iterator to accommodate the varying ways input information can be implemented in SiDB technology. In some cases, such as with Bestagon gates, the binary value 0 may be represented by a perturber placed farther away compared to the 1 state. In contrast, SiQAD gates typically represent 0 by the absence of a perturber and 1 by the presence of a perturber.

In addition, this PR includes the missing experiment scripts needed for temperature simulation.

Checklist:

  • The pull request only contains commits that are related to it.
  • I have added appropriate tests and documentation.
  • I have added a changelog entry.
  • I have created/adjusted the Python bindings for any new or updated functionality.
  • I have made sure that all CI jobs on GitHub pass.
  • The pull request introduces no new warnings and follows the project's style guidelines.

@Drewniok Drewniok added the enhancement New feature or request label Sep 3, 2024
@Drewniok Drewniok self-assigned this Sep 3, 2024
Copy link

codecov bot commented Sep 3, 2024

Codecov Report

Attention: Patch coverage is 98.85057% with 3 lines in your changes missing coverage. Please review.

Project coverage is 98.16%. Comparing base (1547f0c) to head (dcef85c).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...lgorithms/simulation/sidb/critical_temperature.hpp 90.00% 2 Missing ⚠️
...simulation/sidb/displacement_robustness_domain.cpp 98.11% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #521      +/-   ##
==========================================
+ Coverage   98.14%   98.16%   +0.01%     
==========================================
  Files         224      224              
  Lines       31298    31436     +138     
  Branches     1564     1564              
==========================================
+ Hits        30718    30858     +140     
+ Misses        580      578       -2     
Files with missing lines Coverage Δ
...ude/fiction/algorithms/iter/bdl_input_iterator.hpp 100.00% <100.00%> (ø)
...n/algorithms/physical_design/design_sidb_gates.hpp 98.23% <ø> (ø)
...imulation/sidb/calculate_energy_and_state_type.hpp 100.00% <ø> (ø)
...tion/algorithms/simulation/sidb/is_operational.hpp 91.95% <100.00%> (ø)
...s/simulation/sidb/random_sidb_layout_generator.hpp 95.55% <ø> (ø)
...tion/technology/is_sidb_gate_design_impossible.hpp 100.00% <100.00%> (ø)
include/fiction/utils/truth_table_utils.hpp 100.00% <ø> (ø)
...lgorithms/simulation/sidb/critical_temperature.cpp 100.00% <100.00%> (ø)
test/algorithms/simulation/sidb/is_operational.cpp 100.00% <100.00%> (ø)
test/algorithms/simulation/sidb/quickexact.cpp 99.58% <100.00%> (ø)
... and 3 more

... and 4 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1547f0c...dcef85c. Read the comment docs.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Drewniok and others added 2 commits September 5, 2024 05:49
Signed-off-by: GitHub Actions <actions@github.com>
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

Signed-off-by: GitHub Actions <actions@github.com>
@marcelwa
Copy link
Collaborator

marcelwa commented Sep 6, 2024

@Drewniok can you still add a CHANGELOG entry, please?

…mperature_experiments' into update_bdl_input_iterator_and_temperature_experiments
@Drewniok
Copy link
Collaborator Author

Drewniok commented Sep 6, 2024

@Drewniok can you still add a CHANGELOG entry, please?

Done!

docs/changelog.rst Outdated Show resolved Hide resolved
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

clang-tidy made some suggestions

@marcelwa marcelwa merged commit 2541fdb into cda-tum:main Sep 7, 2024
61 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants