Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: 서버 3 레이어 계층 구조화 #2

Merged
merged 4 commits into from
Feb 6, 2023

Conversation

olive-su
Copy link
Contributor

@olive-su olive-su commented Feb 6, 2023

💡 Issue

CD-19 에서 분기했습니다.
CD-68

⚡ Content

  • 서버 구조 짜고 타입 스크립트 적용했습니다.
  • 서버 파일 트리 구조
src
  │   app.js          # App entry point
  └───api ⭐️             # Express route controllers for all the endpoints of the app
  └───config ⭐️          # Environment variables and configuration related stuff
  └─── jobs            # Jobs definitions for agenda.js~
  └───loaders ⭐️        # Split the startup process into modules
  └───models ⭐️         # Database models
  └───services ⭐️       # All the business logic is here
  └───subscribers     # Event handlers for async task
  └───types           # Type declaration files (d.ts) for Typescript
  • 현재 만들어놓은 디렉토리 구조 옆에는 ⭐️ 표시해뒀습니다~

📆 TBD

  • 현재 비디오 업로드 부분 관련해서 route 부분 추가할 예정입니다.
  • production logger 생성할 예정입니다.

🌟 Point

  • 구글 드라이브server/.env에 있는 환경 설정 파일 파일 루트 위치(package.json 위치)에 추가해주세요.
  • 개발용으로 로깅하면 따로 루트 위치 logs 디렉토리에 로그파일 쌓입니다~!

❓ Question

  • 질문

@olive-su olive-su added the ♻️ Refactor Refactor code. label Feb 6, 2023
@olive-su olive-su self-assigned this Feb 6, 2023
@olive-su
Copy link
Contributor Author

olive-su commented Feb 6, 2023

치명적인 실수 해결했습니다.. 🤣
다시 리뷰 부탁드려요-!

Copy link
Member

@nickhealthy nickhealthy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

서버 레이어 계층 나누기 어려웠을 것 같은데 고생 많으셨습니다!
TypeScript 설정도 잘 적용된다니 최고네요! 👍

routes/index.ts Show resolved Hide resolved
Copy link
Contributor

@XxoSio XxoSio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

정말 수고 많으셨습니다.
Good~

@olive-su olive-su merged commit da1970c into cd-carpe-diem:Refactor/CD-68 Feb 6, 2023
@olive-su olive-su deleted the Refactor/CD-68 branch February 6, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
♻️ Refactor Refactor code.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants