fix(non-person) permite login de usuários sem CPF #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mateusKoppe
approved these changes
Dec 16, 2020
|
haha sim, nunca fiquei tão feliz em ver um bug report de algo 😄 Obrigado pelo merge! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Esse PR corrige um erro quando usuários sem CPF tentam se autenticar. Isso acontece com contas do idUFFS vinculadas a setores, como é o caso das coordenações de curso, ex.
computacao.ch.Como a informação de localização da conta (cidate, campus, etc) é importante para esse tipo de usuário (sem CPF), aproveitei e retornei essa info no campo
location.Esse PR não é bem um fix, é um
fix/feature😛P.S. Já rodei todos os testes localmente, inclusive autenticando com a conta da coordenação e minha, e tudo parece estar ok. Como esse fix impacta o app grintex/horarios para produção, não vou esperar muito para o review