Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider pulling en-US changes #7

Open
wants to merge 10 commits into
base: master
Choose a base branch
from

Conversation

ewheelerinc
Copy link

See the commits, there are a few changes to support Android 11.

Also, English is pretty common throughout the world, please consider merging the en-US models to invite additional testing and development.

@ccoreilly
Copy link
Owner

Hi Eric!

Thank you very much for looking into the Android 11 issues, I understand it now works?

There are a lot of changes in your PR, I will make time to review it and merge it. There are some references to your fork in the README which should be updated if we want to merge it here.

As for packaging one language or another, I think it'd be even better if pre-built binaries for all models available are published, English might be pretty common, but it is not everyone's native language.
I have been thinking on maybe building the APK in a GitHub action. At least until someone adds the possibility to download them from within the APK.

Copy link
Owner

@ccoreilly ccoreilly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This commit is already in master. I understand you rebased your changes, which changed the commit hash. Consider squashing your changes so we don't end with duplicate commits.

@ccoreilly
Copy link
Owner

There is also https://github.com/alphacep/vosk-android-service which will have a download UI for vosk models

@ewheelerinc
Copy link
Author

Does vosk-android-service supersede LocalSTT?

@ccoreilly
Copy link
Owner

Does vosk-android-service supersede LocalSTT?

Maybe?

LocalSTT was never meant to be more than a PoC and I do not have time to work on it for now. I would personally like to have a FOSS app for local stt supporting different models, not just vosk (coqui stt, wenet, maybe others), which does not seem the goal of vosk-android-service. However, it looks like vosk-android-service is aiming at offering a good UX and the vosk models are pretty good.

@ewheelerinc
Copy link
Author

Thank you very much for looking into the Android 11 issues, I understand it now works?

It works with AnySoftKeyboard (or was it OpenBoard?) and it loads properly, but doesn't work with other common keyboards using the "microphone" icon. Not sure how AnySoft is different. These are the commits that fix it for Android 11:

  • 9ffb072
  • 97cd1fd - use this tool to repack the .apk after building, may need modified for your privkey and paths and such.

There are a lot of changes in your PR, I will make time to review it and merge it. There are some references to your fork in the README which should be updated if we want to merge it here.

That is fine, I don't need to be referenced necessarily, I just wanted to point at the en-US build if it helps others.

Andrey made a few changes, I originally cloned from his branch. Notably he removed DeepSpeech because of build issues. You said you'd like to see a multi-spech-backend app, so you might revert the DeepSpeech removal and try to fix the build: https://github.com/andreytkachenko/LocalSTT

As for packaging one language or another, I think it'd be even better if pre-built binaries for all models available are published, English might be pretty common, but it is not everyone's native language. I have been thinking on maybe building the APK in a GitHub action. At least until someone adds the possibility to download them from within the APK.

Agreed.

This commit is already in master. I understand you rebased your changes, which changed the commit hash. Consider squashing your changes so we don't end with duplicate commits.

Sorry, which commit? I can rebase if you like, but you might want to look through my changes and see which ones you actually want.

@AhmedX6
Copy link

AhmedX6 commented Jan 24, 2023

This pull request will support english stt ? We should merge it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants