🔧 [mypy] Warn about unreachable code (cjolowicz#1025)

* 🔧 [mypy] Warn about unreachable code * 🔧 [nox] Avoid warning about unreachable code `nox.Session.bin` is no longer `Optional` in recent versions of Nox. * 📚 Document `mypy --warn-unreachable` in User Guide
cclauss · Nov 3, 2021 · b481ada · b481ada
1 parent 671feb0
commit b481ada
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/docs/guide.rst b/docs/guide.rst
@@ -1980,6 +1980,7 @@ The |HPC| enables several configuration options which are off by default.
 The following options are enabled for strictness and enhanced output:
 
 - :option:`strict <mypy --strict>`
+- :option:`warn_unreachable <mypy --warn-unreachable>`
 - :option:`pretty <mypy --pretty>`
 - :option:`show_column_numbers <mypy --show-column-numbers>`
 - :option:`show_error_codes <mypy --show-error-codes>`

diff --git a/{{cookiecutter.project_name}}/noxfile.py b/{{cookiecutter.project_name}}/noxfile.py
@@ -43,8 +43,7 @@ def activate_virtualenv_in_precommit_hooks(session: Session) -> None:
     Args:
         session: The Session object.
     """
-    if session.bin is None:
-        return
+    assert session.bin is not None  # noqa: S101
 
     virtualenv = session.env.get("VIRTUAL_ENV")
     if virtualenv is None:

diff --git a/{{cookiecutter.project_name}}/pyproject.toml b/{{cookiecutter.project_name}}/pyproject.toml
@@ -68,6 +68,7 @@ fail_under = 100
 
 [tool.mypy]
 strict = true
+warn_unreachable = true
 pretty = true
 show_column_numbers = true
 show_error_codes = true