New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow and format non Western Arabic numerals #369

Closed

simon-v-swyftx wants to merge 1 commit into cchanxzy:main from simon-v-swyftx:feat/allow-non-western-arabic-numerals

simon-v-swyftx commented Oct 31, 2024 •

edited

Loading

fixes #366

Probably needs tests


          feat: allow and format non Western Arabic numerals

e146f0a

Owner

cchanxzy commented Nov 12, 2024

@simon-v-swyftx Thanks for the contribution, but looks like your changes will break tests.

More so, like you've mentioned, no tests have been written.

I would not be comfortable considering these changes without sufficient test coverage for the changes.

github-actions bot added the Stale label

github-actions bot closed this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels