Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing type column back to data dict and README feature table #327

Merged

Conversation

jeancochrane
Copy link
Contributor

I noticed while working on the condo model data dict that I had made a small typo in #315 that accidentally wiped the Type column from the data dict and the Features Used table in the README. This PR fixes that typo and rebuilds the data dict and README to match.

@jeancochrane jeancochrane changed the title Add missing type column to data dict and README feature table Add missing type column back to data dict and README feature table Jan 14, 2025
@jeancochrane jeancochrane marked this pull request as ready for review January 14, 2025 20:44
Copy link
Member

@dfsnow dfsnow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah, thanks for doing the chores (so to speak) @jeancochrane. Should we also include a ccao version bump in here? Doesn't seem like it affects the outputs, but couldn't hurt.

@jeancochrane
Copy link
Contributor Author

Should we also include a ccao version bump in here? Doesn't seem like it affects the outputs, but couldn't hurt.

Ooh, good catch @dfsnow! Done in 5075cab, and mirrored to the condo model in ccao-data/model-condo-avm@2aa1667 (I had upgraded the package over there but neglected to snapshot the lockfile).

@@ -1712,15 +1712,15 @@
},
"terra": {
"Package": "terra",
"Version": "1.7-83",
"Version": "1.8-10",
Copy link
Contributor Author

@jeancochrane jeancochrane Jan 14, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this only just started failing now (example) but it seems like raster is no longer installing properly. Updating its main dependency terra to the latest version seems to fix the problem.

@jeancochrane jeancochrane merged commit 7648482 into 2025-assessment-year Jan 14, 2025
4 checks passed
@jeancochrane jeancochrane deleted the jeancochrane/fix-small-errors-in-data-dict branch January 14, 2025 21:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants