-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make the the Python package compatible with Athena PySpark #33
Merged
jeancochrane
merged 9 commits into
jeancochrane/further-python-package-migration
from
jeancochrane/make-python-package-spark-compatible
Dec 4, 2024
Merged
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
7505970
Support Python 3.9, pandas 1.4, and numpy 1.23
jeancochrane df3af62
Try installing pandas/numpy before the other dependencies in pytest-c…
jeancochrane e34b6d7
Try building and testing Python package with tox
jeancochrane 5637158
Add UV_CACHE_DIR to tox env to see if it speeds up builds
jeancochrane 0e29e6f
Revert "Add UV_CACHE_DIR to tox env to see if it speeds up builds"
jeancochrane b410f6e
Restrict tox envs since 3.11 seems to need to build a dep from source
jeancochrane b9f300c
Fix wheel caching on CI when using uv in Python package
jeancochrane 815b6a8
Speed up Python install with uv in docs.yaml
jeancochrane 0890d98
Pass env vars to tox defensively
jeancochrane File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,44 @@ | ||
on: | ||
pull_request: | ||
push: | ||
branches: [main, master] | ||
|
||
name: python-build-and-test | ||
|
||
env: | ||
PYTHONUNBUFFERED: "1" | ||
|
||
jobs: | ||
build-and-test: | ||
runs-on: ubuntu-latest | ||
strategy: | ||
fail-fast: false | ||
matrix: | ||
python-version: ["3.9", "3.10", "3.11", "3.12", "3.13"] | ||
|
||
steps: | ||
- name: Checkout code | ||
uses: actions/checkout@v4 | ||
|
||
- name: Install uv | ||
uses: astral-sh/setup-uv@v4 | ||
with: | ||
enable-cache: true | ||
cache-dependency-glob: python/pyproject.toml | ||
cache-suffix: ${{ matrix.python-version }}-test | ||
|
||
- name: Install Python ${{ matrix.python-version }} | ||
uses: actions/setup-python@v5 | ||
with: | ||
python-version: ${{ matrix.python-version }} | ||
|
||
- name: Install tox | ||
shell: bash | ||
run: | | ||
uv tool install tox --with tox-uv,tox-gh-actions | ||
tox --version | ||
|
||
- name: Build and test with tox | ||
shell: bash | ||
working-directory: python | ||
run: tox r |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We end the
lowest-direct
tests at Python 3.11 sincemyst-parser
didn't add support for 3.12 until 3.0.