Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace TODOs with documentation #774

Merged
merged 2 commits into from
Mar 21, 2024
Merged

Replace TODOs with documentation #774

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4a50838
Replace TODOs with documentation
cberner Mar 21, 2024
e22b348
Update changelog
cberner Mar 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ backwards compatible with 1.x. To upgrade, consider using a pattern like that in
* Remove lifetime from `WriteTransaction` and `ReadTransaction`
* Remove `drain()` and `drain_filter()` from `Table`
* impl `Clone` for `Range`
* Add support for `[T;N]` as a `Value` or `Key` as appropriate for the type `T`
* Add `len()` and `is_empty()` to `MultimapValue`
* Add `retain()` and `retain_in()` to `Table`
* Add `extract_if()` and `extract_from_if()` to `Table`
Expand Down
4 changes: 2 additions & 2 deletions src/tree_store/btree_base.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -143,7 +143,7 @@ pub struct AccessGuard<'a, V: Value> {
len: usize,
on_drop: OnDrop,
_value_type: PhantomData<V>,
// TODO: remove this?
// Used so that logical references into a Table respect the appropriate lifetime
_lifetime: PhantomData<&'a ()>,
}

Expand Down Expand Up @@ -231,7 +231,7 @@ pub struct AccessGuardMut<'a, V: Value> {
offset: usize,
len: usize,
_value_type: PhantomData<V>,
// TODO: can this be removed?
// Used so that logical references into a Table respect the appropriate lifetime
_lifetime: PhantomData<&'a ()>,
}

Expand Down
Loading