Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change "I" to "We" to make it sound like a team project #265

Merged
merged 23 commits into from
Aug 20, 2020
Merged

Change "I" to "We" to make it sound like a team project #265

merged 23 commits into from
Aug 20, 2020

Conversation

eoduniyi
Copy link
Collaborator

This is an example of PR as suggested by the venerable @GegznaV and @bryanhanson

@eoduniyi eoduniyi requested a review from GegznaV August 19, 2020 08:12
@eoduniyi
Update fileio.Rmd
36a8599 
Check for wordiness and weird English rules that linguist care about.
@eoduniyi
Fixed wordiness, mispellings, and grammar
e560480 
This doesn't make a difference to me, but should we avoid personal pronouns ("you", "I", etc.)
@eoduniyi
Fixed mispellings and grammar
4d66ca6
bryanhanson
bryanhanson approved these changes Aug 19, 2020
View reviewed changes
Copy link
Collaborator

@bryanhanson bryanhanson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These are good stylistic changes and in fact please continue to make any changes along these lines w/o seeking a review (just merge these types of changes). I trust your judgement on these. Great work!

@bryanhanson bryanhanson mentioned this pull request Aug 19, 2020
Open
GegznaV
GegznaV requested changes Aug 19, 2020
View reviewed changes
Copy link
Collaborator

@GegznaV GegznaV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition to my remarks, I would like that "one sentence per row" rule would be applied (I see that in some places several sentences per row are used). It makes easier to track and review the text in version control system.

hyperSpec/vignettes/fileio.Rmd Outdated Show resolved Hide resolved
hyperSpec/vignettes/fileio.Rmd Outdated Show resolved Hide resolved
hyperSpec/vignettes/fileio.Rmd Show resolved Hide resolved
hyperSpec/vignettes/fileio.Rmd Outdated Show resolved Hide resolved
hyperSpec/vignettes/fileio.Rmd Outdated Show resolved Hide resolved
hyperSpec/vignettes/fileio.Rmd Outdated Show resolved Hide resolved
hyperSpec/vignettes/fileio.Rmd Outdated Show resolved Hide resolved
hyperSpec/vignettes/fileio.Rmd Outdated Show resolved Hide resolved
hyperSpec/vignettes/fileio.Rmd Outdated Show resolved Hide resolved
eoduniyi
eoduniyi commented Aug 19, 2020
View reviewed changes
Copy link
Collaborator Author

@eoduniyi eoduniyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes made

eoduniyi
eoduniyi commented Aug 19, 2020
View reviewed changes
Copy link
Collaborator Author

@eoduniyi eoduniyi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it

@eoduniyi
Revise "## Witec {#sec:read-txt-Witec}" section
3d880f6
@eoduniyi
Revise "## Horiba / Jobin Yvon (e.g. LabRAM) {#sec:read-txt-Horiba}" …
55616d3 
…section
@eoduniyi
Revise "### Renishaw ASCII data {#sec:read-txt-Renishaw-ASCII}" section
43aae98
@eoduniyi
Revise "## Renishaw Raman {#sec:read-txt-Renishaw}" section
0122f31
@eoduniyi
Revise "### Kaiser Optical Systems Raman Maps {#sec:read-spc-KaiserMa…
b292e30 
…p}" section
@eoduniyi
Revise "## Kaiser Optical Systems Raman {#sec:Kaiser}" section
900b7df
@eoduniyi
Revise "## Nicolet FT-IR Imaging {#sec:read-ENVI-Nicolet}" section
0510eb1
@eoduniyi
Revise "## Bruker FT-IR Imaging {#sec:read-ENVI-Bruker}" section
47e1686
@eoduniyi
Revise "## Manufacturer Specific Import Functions {#sec:manuf-spec-im…
fa7fb21 
…port}" section
@eoduniyi
Revise "### Deriving manufacturer specific import filters" section
5e7fbcb
@eoduniyi
Revise "## spc Files {#sec:read-spc}" section
61dd864
@eoduniyi
Revise "## ENVI Files {#sec:read-ENVI}" section
2a9afa5
@eoduniyi
Revise "## Matlab Files {#sec:readMat}" section
fd30390
@eoduniyi
Revise "# ASCII files {#sec:ascii}" section
82f9858
@GegznaV GegznaV added the Topic: vignette 📗 Related to vignettes of hyperSpec label Aug 20, 2020
GegznaV
GegznaV requested changes Aug 20, 2020
View reviewed changes
Copy link
Collaborator

@GegznaV GegznaV left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One more remark: the branch should have been named as feature/vign-edits and not vign-edits.

hyperSpec/vignettes/fileio.Rmd Outdated Show resolved Hide resolved
hyperSpec/vignettes/fileio.Rmd Show resolved Hide resolved
@GegznaV
Copy link
Collaborator

GegznaV commented Aug 20, 2020

It's enough changes for a single PR. Merging it.

@GegznaV GegznaV merged commit 2b69981 into develop Aug 20, 2020
@GegznaV GegznaV deleted the vign-edits branch August 20, 2020 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bryanhanson bryanhanson bryanhanson approved these changes

@GegznaV GegznaV GegznaV approved these changes

Assignees
No one assigned
Labels
Topic: vignette 📗 Related to vignettes of hyperSpec
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@eoduniyi @GegznaV @bryanhanson