Refactor an each/else to an if/each/else to work around an Ember bug #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
See emberjs/ember.js#12716 This problem occurs when using a 'collapsable' table. When a row group is initially rendered in the collapsed state it `yield`s; any {{table-columns}} used inside here aren't cleaned up properly (they're removed from the DOM but `willDestroyElement` is never called so they never unregister, and the corresponding header will always hold a reference to this outdated component.)
|
👍 For some reason I never got the notification about this and totally missed the PR. Sorry for the delay. |
cball
added a commit
that referenced
this pull request
Feb 13, 2016
Refactor an each/else to an if/each/else to work around an Ember bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See emberjs/ember.js#12716
This problem occurs when using a 'collapsable' table.
When a row group is initially rendered in the collapsed state it
yields; any{{table-column}}components rendered inside here aren't cleaned up properly (they're removed from the DOM butwillDestroyElementis never called so they never unregister). The lack of unregistration means that the corresponding header will always hold a reference to this "frozen-in-time" component.