fix cache entry expiration - monotinic vs realtime #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yurique
changed the title
|
The tests make sense to me, but would be great if someone could double-check :) |
kubukoz
approved these changes
Sep 23, 2021
kubukoz
reviewed
Sep 23, 2021
|
|
||
| behavior of "get put with TTL" | ||
|
|
||
| it should "store the given key-value pair in the underlying cache with the given TTL, then get it back when not expired" in ticked { |
There was a problem hiding this comment.
Let's have another one like this, but with an IO.sleep between put and get. It'll be instant because of how ticked works.
There was a problem hiding this comment.
Added a couple of tests with sleep.
|
Thanks! I always mix up the two kinds of clocks, this whole thing reminded me what the difference is 😅 |
kubukoz
approved these changes
Sep 23, 2021
|
Think we could remove expired keys if we read one, as a space optimization - but that can be a different PR :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #522