Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Expiration of Caffeine Cache #562

Merged
merged 2 commits into from
Sep 9, 2021
Merged

Fix Expiration of Caffeine Cache #562

merged 2 commits into from
Sep 9, 2021

Conversation

zarthross
Copy link
Contributor

Fixes #522

@PawelJ-PL PawelJ-PL mentioned this pull request Sep 9, 2021
Closed
zarthross and others added 2 commits September 9, 2021 15:04
@zarthross @kubukoz
Fix Expiration of Caffeine Cache
912acc1
@kubukoz
Rename: isNotExpired -> isBeforeExpiration, refactor
60ef3e7 
Simplified the logic a bit, as it was super confusing with the weird
pattern match on Option.
@kubukoz
Copy link
Collaborator

kubukoz commented Sep 9, 2021

Thanks. I updated to master and made some simplifications to the super confusing code I wrote in the first place :D

@kubukoz kubukoz merged commit e1b730d into cb372:master Sep 9, 2021
@zarthross zarthross deleted the fix-caffeine branch September 9, 2021 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Get returns nothing when TTL set
2 participants
@zarthross @kubukoz