Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Introduce message builder #363

Merged
merged 6 commits into from
Sep 13, 2024
Merged

Introduce message builder #363

merged 6 commits into from
Sep 13, 2024

Conversation

jmike
Copy link
Contributor

@jmike jmike commented Aug 18, 2024

Introduce the concept of MessageBuilder to produce user-friendly error messages. Provide examples and documentation.

Fixes #357

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 18, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: e8dc9ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@jmike jmike mentioned this pull request Aug 18, 2024
Closed
1 task
thanoskrg
thanoskrg reviewed Aug 27, 2024
View reviewed changes
Copy link
Contributor

@thanoskrg thanoskrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Super clean implementation - this is heading to the right direction 👌

Left some suggestions to discuss, but nothing major or blocker.

README.md Outdated Show resolved Hide resolved
README.md Show resolved Hide resolved
lib/MessageBuilder.test.ts Outdated Show resolved Hide resolved
lib/fromZodError.ts Show resolved Hide resolved
lib/fromZodIssue.ts Show resolved Hide resolved
lib/fromZodIssue.ts Show resolved Hide resolved
lib/fromZodIssue.ts Show resolved Hide resolved
lib/index.ts Show resolved Hide resolved
lib/MessageBuilder.ts Show resolved Hide resolved
@jmike
Copy link
Contributor Author

jmike commented Sep 12, 2024 •
edited
Loading

@thanoskrg I've addressed most of your comments and responded to your questions. Please have a look - let's try to close this tomorrow if we can.

thanoskrg
thanoskrg reviewed Sep 12, 2024
View reviewed changes
Copy link
Contributor

@thanoskrg thanoskrg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One small detail to address in README examples before we merge.

README.md Show resolved Hide resolved
lib/fromZodIssue.ts Show resolved Hide resolved
@jmike jmike merged commit 280be9b into main Sep 13, 2024
4 checks passed
@jmike jmike deleted the feat-message-builder branch September 13, 2024 13:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thanoskrg thanoskrg thanoskrg approved these changes

@nikoskalogridis nikoskalogridis Awaiting requested review from nikoskalogridis

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Provide a message builder option
2 participants
@jmike @thanoskrg