Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: evelenty and astro icons #82

Merged
merged 2 commits into from
Jan 27, 2024
Merged

feat: evelenty and astro icons #82

merged 2 commits into from
Jan 27, 2024

Conversation

prazdevs
Copy link
Member

@prazdevs prazdevs commented Jan 27, 2024

closes #75
closes #76

@prazdevs prazdevs self-assigned this Jan 27, 2024
@prazdevs prazdevs merged commit 58bb1a8 into main Jan 27, 2024
1 check passed
Comment on lines +47 to +52
'astro.config.js',
'astro.config.mjs',
'astro.config.cjs',
'astro.config.ts',
'astro.config.cts',
'astro.config.mts',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These extensions don't look right? I didn't say mts or cts... those don't appear to be supported by Astro.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

mts and cts are just ways to compile ts explicitely to cjs/mjs, i put them as a future-proof thing that involve 0 risk

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@prazdevs prazdevs deleted the feat/astro-eleventy branch January 28, 2024 19:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Astro icon Add Eleventy icon
2 participants