Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: re-generate previews #297

Merged
merged 1 commit into from
Sep 13, 2024
Merged

chore: re-generate previews #297

merged 1 commit into from
Sep 13, 2024

Conversation

github-actions[bot]
Copy link
Contributor

Automated changes by create-pull-request GitHub action

@uncenter
Copy link
Member

Why make the "GitHub actor" the committer?

author: ${{ github.actor }} <${{ github.actor }}@users.noreply.github.com>

Seems more logical to make it just be the bot instead of it looking like you committed these changes.

@sgoudham
Copy link
Contributor

Interestingly I don't remember setting that or the signoff values, will need to make a PR to make it more like the workflows in the org 🤔

@uncenter
Copy link
Member

uncenter commented Sep 13, 2024

If you just remove that author: ... line entirely it will default to GitHub Actions [bot] user.

EDIT: You also don't need to set committer: ..., it too defaults to GitHub Actions [bot] user.

@uncenter
Copy link
Member

uncenter commented Sep 13, 2024

I mean this seems like a pretty good starting point (only the "required" stuff): https://github.com/catppuccin/github-file-explorer-icons/blob/9d4828d7a60be1d3b2fea19da8ec8e531e578645/.github/workflows/vscode-icons.yml#L28-L35.

@github-actions github-actions bot force-pushed the chore/re-generate-previews branch from 8396f79 to 7b593bc Compare September 13, 2024 01:52
@sgoudham sgoudham merged commit 944c958 into main Sep 13, 2024
@sgoudham sgoudham deleted the chore/re-generate-previews branch September 13, 2024 01:55
@uncenter
Copy link
Member

Ah I guess since it is/can be triggered on push it co-authors the user who triggered it, whereas ghfei is just on a schedule so we don't see that. Anyway this is better, nice :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants