ci: add previews.yml
to re-generate assets
#232
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR comes from my frustration on the lack of good font rendering on Linux.
I was trying to re-generate the previews to get them to match the existing previews. Unfortunately, Puppeteer seems to struggle with consistency across operating systems as highlighted in puppeteer/puppeteer#661
I tried the solutions commented in the above issue but nothing seemed to work. Ultimately, I gave up and decided to try and see if we can make it a concern of the CI. I was finally successful and this PR adds a new workflow
previews.yml
that re-generates the individual flavour previews and the catwalk preview.You can view the output of a successful run in sgoudham/ci-playground#10
Limitations / Concerns:
macos-latest
runner which is basically the entire reason why the font rendering matches up with the existing previews.