refactor(wikipedia): rewrite #1075
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As mentioned in Discord; this rewrite is pretty usable for the most part, and most of the unthemed stuff you'll find is due to whatever element not properly using vars. I'd expect them to continue fixing issues like that as the rollout progresses and I think we'll wait a bit before merging. |
This comment was marked as resolved.
This comment was marked as resolved.
|
this is not colored btw |
|
As I said:
I don't plan to theme stuff not using vars. I expect they will fix issues like that one in the future. |
|
Oh I see! |
uncenter
force-pushed
the
refactor/wikipedia-rewrite
branch
from
85882f8 to
ad474ec
Compare
…ot pages, language config
|
Ended up theming the root and home pages that don't look like they are getting variables any time soon. Theme is usable, don't see any unthemed areas except for inline stuff. Should be good to go. |
isabelroses
previously approved these changes
Jan 1, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rewrites Wikipedia! Their new dark mode support means they finally switched to properly using vars, so this works!