Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed black start page for all 4 Catppuccin variants. #3

Merged
merged 4 commits into from
Dec 30, 2024

Conversation

PsychedelicShayna
Copy link
Contributor

@PsychedelicShayna PsychedelicShayna commented Dec 25, 2024

The new specification introduced a .figmatokens file format that lives alongside the .creatortheme; this PR resolves this currently open issue by simply adding a .figmatokens file for every variant, using the default dark.figmatokens as a baseline, and replacing the color values with the appropriate ones from the theme flavor.

Preview

Here is how each variant currently looks like after including the .figmatokens files for each respective flavor.

Mocha

image

Frappe

image

Macciato

ksnip_tmp_hlchRl

Latte

ksnip_tmp_fOwlaa

Addendum

While this resolves the problem, a separate (non-issue) aesthetic enhancement could still be done by taking the official color palette from catppuccin.com and then using its variation of, for example, green, of which there only exists one value per the standard variants, and then applying the delta between the R, G, and B values of the the default green colors of, for instance, the Token_Accent colors, of which there are three shades:

ksnip_tmp_EbhnJK

And using that delta, plus or minus whatever is necessary to get it into a color range compatible with the rest of the theme's colors (as long as the +/- is applied to all three shades equally, across each R, G, and B value) in order to maintain the consistency of the shade differences, but using Catppuccin's definition of green as a base rather than the standard dark theme, or whichever other default theme's definition of green.

So it could still be improved further. Although, the important part is that the issue is resolved.

@PsychedelicShayna
Copy link
Contributor Author

Note

This fix as it stands does make the highlight color of the sidebar buttons monochrome, however without the fix, it appears to be colored green, which is incorrect regardless.

This can be addressed in a separate PR as it's just a matter of finding the correct color value. The important part is that the start page isn't blanked.

Original

image

Broken

image

With Fix

image

@backwardspy
Copy link
Member

thanks for the fix & detailed explanation! i'm happy with this for a start, it's much better than the current state of the theme. nice work!

@backwardspy backwardspy merged commit 9e5d41b into catppuccin:main Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Welcome/examples page completely black
2 participants