Match color.RGBA() behavior from the standard library
#30
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The template requires whisker 2.5.1 but in nix we were stuck with 2.3.0
I think this was the intended behavior, we want the colors to be fully opaque.
caarlos0
approved these changes
Dec 30, 2024
|
No strong feelings about RGBA8, I just put it there to preserve the original behavior, I'm also not 100% on it since the RGB slice is available and contains the same data. If you don't think it is necessary to keep I can remove it no problem. Thanks for the review :) |
|
yeah I think we can remove it then :) thanks for the PR, btw ❤️ |
In the standard library color.RGBA() expects returned values to be in the interval [0, 0xffff]. With this patch we match the behavior of image.color.RGBA.RGBA(). Tests were updated accordingly and a test was added to make sure we match the implementation of the standard library.
|
Alright, should be good to go :) |
|
thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #29.
See original issue and commit messages.