-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat!(hyprcursor): implement nominal_size metadata #63
feat!(hyprcursor): implement nominal_size metadata #63
Conversation
requires hyprcursor at least 0.1.11 This will fix users having to set multiple sizes on hyprland
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this technically a breaking change?
I believe hypr* will just disregard the extra (nominal) data if they aren't on .11. I can double check for sure if you'd like? |
Sure, that'd be appreciated. A breaking change is anything that will cause the user to change their settings so I'm wondering if merging this will default their cursor to a different size to what the current release has, in which case we should definitely ship this as a breaking change. |
Ah yeah then its def a breaking change. (Even though its 'technically' more correct :p) |
I believe, an average Hyprland user will be able to figure out - why the cursor got bigger and change its size. |
Sure, but that won't change us shipping it as a breaking change 👍 |
yeah extra data is ignored. this is alright to merge I believe |
requires hyprcursor at least 0.1.11
This will fix users having to set multiple sizes on hyprland
see hyprwm/hyprcursor/pull/73
With this merge #31 (comment) & #55 (comment) don't apply anymore and users can set one size and expect them to apply at the same scale.
BEGIN_COMMIT_OVERRIDE
feat!: implement nominal_size metadata for hyprcursor
END_COMMIT_OVERRIDE