Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat!(hyprcursor): implement nominal_size metadata #63

Merged
merged 2 commits into from
Dec 27, 2024

Conversation

Covkie
Copy link
Contributor

@Covkie Covkie commented Dec 21, 2024

requires hyprcursor at least 0.1.11

This will fix users having to set multiple sizes on hyprland

see hyprwm/hyprcursor/pull/73

With this merge #31 (comment) & #55 (comment) don't apply anymore and users can set one size and expect them to apply at the same scale.

BEGIN_COMMIT_OVERRIDE
feat!: implement nominal_size metadata for hyprcursor
END_COMMIT_OVERRIDE

requires hyprcursor at least 0.1.11

This will fix users having to set multiple sizes on hyprland
Copy link
Contributor

@sgoudham sgoudham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this technically a breaking change?

@Covkie
Copy link
Contributor Author

Covkie commented Dec 24, 2024

Is this technically a breaking change?

I believe hypr* will just disregard the extra (nominal) data if they aren't on .11. I can double check for sure if you'd like?

@sgoudham
Copy link
Contributor

Sure, that'd be appreciated.

A breaking change is anything that will cause the user to change their settings so I'm wondering if merging this will default their cursor to a different size to what the current release has, in which case we should definitely ship this as a breaking change.

@Covkie
Copy link
Contributor Author

Covkie commented Dec 24, 2024

Ah yeah then its def a breaking change. (Even though its 'technically' more correct :p)

@izmyname
Copy link

Ah yeah then its def a breaking change. (Even though its 'technically' more correct :p)

I believe, an average Hyprland user will be able to figure out - why the cursor got bigger and change its size.

@sgoudham
Copy link
Contributor

I believe, an average Hyprland user will be able to figure out - why the cursor got bigger and change its size.

Sure, but that won't change us shipping it as a breaking change 👍

@sgoudham sgoudham changed the title feat(hyprcursor): implement nominal_size metadata feat!(hyprcursor): implement nominal_size metadata Dec 25, 2024
@Covkie
Copy link
Contributor Author

Covkie commented Dec 27, 2024

yeah extra data is ignored. this is alright to merge I believe

@Covkie Covkie requested a review from sgoudham December 27, 2024 13:21
@sgoudham sgoudham merged commit 6649d37 into catppuccin:main Dec 27, 2024
1 check passed
@Covkie Covkie deleted the feat/hyprcursor-nominal_size branch December 28, 2024 18:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants