build: making it so ephemeral list-type arguments are appended to existing list-type arguments #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbohren
force-pushed
the
feature-append-list-args
branch
from
abc4e82 to
00962f7
Compare
| if k in Context.KEYS and v is not None])) | ||
| for (k,v) in opts_vars.items(): | ||
| if k in Context.KEYS and v is not None: | ||
| if append and type(context_args.get(k,None)) is list and type(v) is list: |
jbohren
force-pushed
the
feature-append-list-args
branch
from
00962f7 to
a13f9ce
Compare
|
@wjwwood I'll update the |
jbohren
force-pushed
the
feature-append-list-args
branch
from
a13f9ce to
af7260c
Compare
…sting list-type arguments - affects behavior of --cmake-args, --make-args, and --catkin-make-args - fixes broken --no-catkin-make-args (fixes catkin#136)
jbohren
force-pushed
the
feature-append-list-args
branch
from
af7260c to
4007bcd
Compare
wjwwood
added a commit
that referenced
this pull request
Mar 16, 2015
build: making it so ephemeral list-type arguments are appended to existing list-type arguments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to add additional CMake arguments on top of the arguments in a given profile.
@adeguet1 does this do what you needed?