Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(Dropdown.jsx): Migrated to css, removed theme prop of d.ts and u… #592

Merged
merged 1 commit into from
Oct 15, 2024

Conversation

MarcosViniciusPC
Copy link
Contributor

Description

https://jirasoftware.catho.com.br/browse/QTM-712

Review guide

  • Unit tests (yarn test:components)
  • Regression
    - first start the storybook for regression tests(and keep it open): yarn test:regression:storybook;
    - then run the regression tests: yarn test:regression
  • Code review
  • TypeScript updated
  • Build

How to test build

How to test visual changes

Note:

  • It is important to check states (hover, focus, disabled, etc.), as they are not valid for regressive tests (yarn test:regression)

Copy link

@MarcosViniciusPC MarcosViniciusPC merged commit 0c79e9f into beta Oct 15, 2024
3 checks passed
@MarcosViniciusPC MarcosViniciusPC deleted the QTM-712 branch October 15, 2024 12:00
Copy link

🎉 This PR is included in version 10.0.0-beta.15 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants