docs(Alert.mdx): Removing onClose from component usage examples and a… #591
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…dding component-specific exampl
|
simone-shiozawa
approved these changes
Oct 11, 2024
UlissesMantovani
approved these changes
Oct 11, 2024
OtavioBernardes
approved these changes
Oct 11, 2024
|
🎉 This PR is included in version 10.0.0-beta.16 🎉 The release is available on: Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 9.33.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…dding component-specific exampl
Description
https://jirasoftware.catho.com.br/browse/QTM-784
Review guide
Note
When the onClose prop is not passed, the close button is not displayed. Therefore, we do not need to implement this feature. I believe that this task was created because in the doc the close button is always visible, as an onClose function is passed to all usage examples, not making it clear that the prop is optional. I'm just going to update the doc, adding an example of specific use of the Alert component with the option to show the close button, and from the other examples remove the onClose prop so as not to display the button.