Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding new icon (DescriptionOutlinedIcon) #581

Merged
merged 5 commits into from
Aug 29, 2024
Merged

feat: adding new icon (DescriptionOutlinedIcon) #581

merged 5 commits into from
Aug 29, 2024

Conversation

leticiabiazioli
Copy link
Contributor

Description

Adding DescriptionOutlinedIcon

Setup

to view the components behavior, run yarn storybook

Review guide

  • Coverage (coverage status should not regress)
    - yarn test:coverage
  • Unit tests (yarn test:components)
  • Regression
    - first start the storybook for regression tests(and keep it open): yarn test:regression:storybook;
    - then run the regression tests: yarn test:regression
  • Code review
  • TypeScript updated

A11y review

  • A11y checks
    • accessible via keyboard?
    • Identifiable through assistive technology (screen-reader chrome extension)?
    • Semantically correct html elements (or if necessary identified by WAI-ARIA)?
    • Is there a deficiency in color contrast?

Browsers review

  • Layout review
    • Edge
    • Firefox
    • Chrome
    • Safari
    • Mobile
  • Ux review validation

@leticiabiazioli leticiabiazioli changed the title feat(adding new icon): adding new icon feat: adding new icon (DescriptionOutlinedIcon) Aug 29, 2024
alizeleal
alizeleal previously approved these changes Aug 29, 2024
View reviewed changes
@MarcosViniciusPC MarcosViniciusPC added status:reviewing Someone is reviewing this PR and removed status:pending review labels Aug 29, 2024
MarcosViniciusPC
MarcosViniciusPC requested changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@MarcosViniciusPC MarcosViniciusPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ ] Code review

Add new icon to components/Icon/index.d.ts

components/Icon/Icon.jsx Outdated Show resolved Hide resolved
components/Icon/Icon.jsx Outdated Show resolved Hide resolved
components/shared/icons.js Outdated Show resolved Hide resolved
@MarcosViniciusPC MarcosViniciusPC added status:fix status:suggestion and removed status:reviewing Someone is reviewing this PR labels Aug 29, 2024
leticiabiazioli and others added 3 commits August 29, 2024 15:40
@leticiabiazioli @MarcosViniciusPC
Update components/shared/icons.js
fc4228a 
Co-authored-by: MarcosViniciusPC <105747728+MarcosViniciusPC@users.noreply.github.com>
@leticiabiazioli @MarcosViniciusPC
Update components/Icon/Icon.jsx
efc4266 
Co-authored-by: MarcosViniciusPC <105747728+MarcosViniciusPC@users.noreply.github.com>
@leticiabiazioli @MarcosViniciusPC
Update components/Icon/Icon.jsx
0de9779 
Co-authored-by: MarcosViniciusPC <105747728+MarcosViniciusPC@users.noreply.github.com>
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@MarcosViniciusPC MarcosViniciusPC added the issue:wip Someone is solving this problem label Aug 29, 2024
MarcosViniciusPC
MarcosViniciusPC approved these changes Aug 29, 2024
View reviewed changes
Copy link
Contributor

@MarcosViniciusPC MarcosViniciusPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[x] Code review

@MarcosViniciusPC MarcosViniciusPC added status:approved and removed issue:wip Someone is solving this problem labels Aug 29, 2024
@MarcosViniciusPC MarcosViniciusPC merged commit 819e5ef into master Aug 29, 2024
3 checks passed
@github-actions GitHub Actions
Copy link

🎉 This PR is included in version 9.31.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@MarcosViniciusPC MarcosViniciusPC deleted the feat/RA-4854 branch October 9, 2024 20:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarcosViniciusPC MarcosViniciusPC MarcosViniciusPC approved these changes

@alizeleal alizeleal alizeleal left review comments

Assignees
No one assigned
Labels
released status:approved
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@leticiabiazioli @alizeleal @MarcosViniciusPC