Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat.QTM-726 - Updates Yarn.lock #567

Closed
wants to merge 2 commits into from
Closed

feat.QTM-726 - Updates Yarn.lock #567

wants to merge 2 commits into from

Conversation

alizeleal
Copy link
Contributor

Description

https://jirasoftware.catho.com.br/browse/QTM-726

Setup

to view the components behavior, run yarn storybook

Review guide

  • Coverage (coverage status should not regress)
    - yarn test:coverage
  • Unit tests (yarn test:components)
  • Regression
    - first start the storybook for regression tests(and keep it open): yarn test:regression:storybook;
    - then run the regression tests: yarn test:regression
  • Code review
  • TypeScript updated

A11y review

  • A11y checks
    • accessible via keyboard?
    • Identifiable through assistive technology (screen-reader chrome extension)?
    • Semantically correct html elements (or if necessary identified by WAI-ARIA)?
    • Is there a deficiency in color contrast?

Browsers review

  • Layout review
    • Edge
    • Firefox
    • Chrome
    • Safari
    • Mobile
  • Ux review validation

Copy link

@MarcosViniciusPC MarcosViniciusPC added status:reviewing Someone is reviewing this PR and removed status:pending review labels Jun 20, 2024
Copy link
Contributor

@MarcosViniciusPC MarcosViniciusPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[ ] Unit

Updating yarn.lock updates the react version and consequently generates errors in all components that use defaultProps.
image

@MarcosViniciusPC MarcosViniciusPC added status:blocked and removed status:reviewing Someone is reviewing this PR labels Jun 20, 2024
@alizeleal
Copy link
Contributor Author

alizeleal commented Jul 22, 2024

Done in React update pull request

@alizeleal alizeleal closed this Jul 22, 2024
@alizeleal alizeleal deleted the QTM-726 branch July 22, 2024 21:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants