Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(icon): add lightbulb_outlined icon #560

Merged
merged 1 commit into from
May 9, 2024

Conversation

LeonardsonCC
Copy link
Member

Description

Add lightbulb outlined icon

Setup

To view the components behavior, run yarn storybook

Review guide

  • Coverage (coverage status should not regress)
    - yarn test:coverage
  • Unit tests (yarn test:components)
  • Regression
    - first start the storybook for regression tests(and keep it open): yarn test:regression:storybook;
    - then run the regression tests: yarn test:regression
  • Code review
  • TypeScript updated

A11y review

  • A11y checks
    • accessible via keyboard?
    • Identifiable through assistive technology (screen-reader chrome extension)?
    • Semantically correct html elements (or if necessary identified by WAI-ARIA)?
    • Is there a deficiency in color contrast?

Browsers review

  • Layout review
    • Edge
    • Firefox
    • Chrome
    • Safari
    • Mobile
  • Ux review validation

@LeonardsonCC LeonardsonCC self-assigned this May 9, 2024
Copy link

sonarqubecloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

Copy link
Contributor

@alizeleal alizeleal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Code Review
  • Documentation
  • Tests

@alizeleal alizeleal added status:pending review and removed status:reviewing Someone is reviewing this PR labels May 9, 2024
@MarcosViniciusPC MarcosViniciusPC added status:reviewing Someone is reviewing this PR and removed status:pending review labels May 9, 2024
Copy link
Contributor

@MarcosViniciusPC MarcosViniciusPC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[x] Code review
[x] Doc

@MarcosViniciusPC MarcosViniciusPC added status:approved and removed status:reviewing Someone is reviewing this PR labels May 9, 2024
@MarcosViniciusPC MarcosViniciusPC merged commit d80541e into master May 9, 2024
3 checks passed
@delete-merged-branch delete-merged-branch bot deleted the feat/add-lightbulb-icon branch May 9, 2024 15:21
Copy link

github-actions bot commented May 9, 2024

🎉 This PR is included in version 9.27.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Copy link

🎉 This PR is included in version 10.0.0-beta.3 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants