dnp3: : do not log empty notify array

Ticket: OISF#5167
catenacyber · Jul 4, 2022 · 8fe77d9 · 8fe77d9
1 parent b71fff5
commit 8fe77d9
Showing 1 changed file with 3 additions and 3 deletions.
diff --git a/src/output-json-dnp3.c b/src/output-json-dnp3.c
@@ -64,18 +64,18 @@ static void JsonDNP3LogLinkControl(JsonBuilder *js, uint8_t lc)
 
 static void JsonDNP3LogIin(JsonBuilder *js, uint16_t iin)
 {
-    jb_open_array(js, "indicators");
-
     if (iin) {
+        jb_open_array(js, "indicators");
+
         int mapping = 0;
         do {
             if (iin & DNP3IndicatorsMap[mapping].value) {
                 jb_append_string(js, DNP3IndicatorsMap[mapping].name);
             }
             mapping++;
         } while (DNP3IndicatorsMap[mapping].name != NULL);
+        jb_close(js);
     }
-    jb_close(js);
 }
 
 static void JsonDNP3LogApplicationControl(JsonBuilder *js, uint8_t ac)