errors replacements are labeled as faster #38
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mmorel-35
force-pushed
the
replacement-diagnostics
branch
from
e61e308 to
6ec2134
Compare
ccoVeille
approved these changes
Nov 21, 2024
alexandear
approved these changes
Nov 22, 2024
catenacyber
reviewed
Nov 24, 2024
mmorel-35
force-pushed
the
replacement-diagnostics
branch
from
6ec2134 to
11df7ac
Compare
mmorel-35
changed the title
|
Needs a rebase now |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
mmorel-35
force-pushed
the
replacement-diagnostics
branch
from
11df7ac to
3f9d2a7
Compare
|
@catenacyber , |
ccoVeille
approved these changes
Nov 27, 2024
alexandear
reviewed
Nov 27, 2024
Comment on lines
+32
to
+40
| fmt.Sprintf("%s", errSentinel) // want "fmt.Sprintf can be replaced with faster errSentinel.Error()" | ||
| fmt.Sprintf("%v", errSentinel) // want "fmt.Sprintf can be replaced with faster errSentinel.Error()" | ||
| fmt.Sprint(errSentinel) // want "fmt.Sprint can be replaced with faster errSentinel.Error()" | ||
| fmt.Sprintf("%s", io.EOF) // want "fmt.Sprintf can be replaced with faster io.EOF.Error()" | ||
| fmt.Sprintf("%v", io.EOF) // want "fmt.Sprintf can be replaced with faster io.EOF.Error()" | ||
| fmt.Sprint(io.EOF) // want "fmt.Sprint can be replaced with faster io.EOF.Error()" | ||
| fmt.Sprintf("%s", err) // want "fmt.Sprintf can be replaced with faster err.Error()" | ||
| fmt.Sprintf("%v", err) // want "fmt.Sprintf can be replaced with faster err.Error()" | ||
| fmt.Sprint(err) // want "fmt.Sprint can be replaced with faster err.Error()" |
There was a problem hiding this comment.
Changing the report message constitutes a breaking change. However, the PR's title states "chore: define newFasterFunctionReplacementDiagnostic," which suggests it's a simple refactoring. I propose we either change the PR's title or avoid making breaking changes.
There was a problem hiding this comment.
That's related to this #38 (comment)
mmorel-35
changed the title
mmorel-35
changed the title
mmorel-35
changed the title
|
Why was it closed? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.