Adding Heart Shape #193
Closed
Adding Heart Shape #193
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fenilmodi00
approved these changes
Sep 16, 2023
fenilmodi00
approved these changes
Sep 16, 2023
catdad
requested changes
Sep 28, 2023
Comment on lines
+360
to
+361
| var width = 15; | ||
| var height = 15; |
There was a problem hiding this comment.
It seems that the scalar input value is not implemented. The size of the hearts is hardcoded, which should not be the case. The default size also seems to be quite a bit larger than the other confetti.
|
I am closing this PR in favor of #203. The new custom shapes support wobbling and rendering flat and are fully scalable. There is a heart available in the example that was included in that PR. It has been shipped in version 1.8.0. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting ready for Valentine's Day.
Thanks for all the hard work.