Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update catch.hpp #842

Closed
wants to merge 1 commit into from
Closed

Update catch.hpp #842

wants to merge 1 commit into from

Conversation

tocic
Copy link
Contributor

@tocic tocic commented Mar 4, 2017

add const ref to function parameters

Description

GitHub Issues

add const ref to function parameters
@horenmar
Copy link
Member

horenmar commented Mar 4, 2017

Please do not submit pull requests changing the version.hpp
or the single-include catch.hpp file, these are changed
only when a new release is made.

...

There are actually more places where reporters take the string by value instead of by-reference, I'll take a look and fix them up tomorrow.

@horenmar horenmar closed this in e95bf48 Mar 6, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants