Compiler compatibility for Visual Studio 2017 (v141) #2822
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…end operator == (catchorg#2792). Make the operator not-friend is a sufficient solution. Closes catchorg#2792
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## devel #2822 +/- ##
=======================================
Coverage 91.33% 91.33%
=======================================
Files 197 197
Lines 8289 8289
=======================================
Hits 7570 7570
Misses 719 719 |
|
Thanks I guess, I would happily leave VS 2017 unsupported. 😃 |
|
Thanks a lot!! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The problem with (and only with) Visual Studio 2017 was that the
friend bool operator==could not sufficient resolved / matched for a template class. In this case it was caused by theExtendedMultResult.An detailed description of the porblem and the boiled down problem can be found in the issue #2792.
As Martin mentioned in the issue #2792: Make the operator not-friend is a sufficient solution.
GitHub Issues
Compiler problem with operator and include catch_all.hpp #2792