Add deprecation warning in ParseAndCatchTests #2120
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## v2.x #2120 +/- ##
=======================================
Coverage 88.79% 88.79%
=======================================
Files 138 138
Lines 5683 5683
=======================================
Hits 5046 5046
Misses 637 637 |
|
This should also be explicitly written in the cmake integration docs. |
|
@horenmar Do we need to document this also in the deprecations information or should that only contain changes in Catch directly and not in the CMake integration? |
|
@norbertwenzel It should be there as well. |
horenmar
added
Extras
|
Ok, I think I have everything covered in the documentation now. Let me know should there be something missing still. |
|
lgtm. Autorebase and the PR is ready to be merged. |
norbertwenzel
force-pushed
the
deprecate_ParseAndAddCatchTests
branch
from
7b2ff07
to
a95a5ff
Compare
Parsing C++ with regex in CMake is error prone and regularly leads to silently dropped (not run) test cases. Going forward the function `catch_discover_tests` from `contrib/CMake.cmake` should be used. For more information see catchorg#2092 (comment)
NeroBurner
force-pushed
the
deprecate_ParseAndAddCatchTests
branch
from
a95a5ff
to
0107383
Compare
|
@norbertwenzel did squash the commits, now rebased on current |
norbertwenzel
approved these changes
Dec 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Parsing C++ with regex in CMake is error prone and regularly leads to silently
dropped (not run) test cases.
Going forward the function
catch_discover_testsfromcontrib/CMake.cmakeshould be used.
For more information see #2092 (comment)