Patch:Failure to pass special chars through input file #1769
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1769 +/- ##
=========================================
+ Coverage 87.61% 87.81% +0.2%
=========================================
Files 137 137
Lines 5406 5413 +7
=========================================
+ Hits 4736 4753 +17
+ Misses 670 660 -10 |
horenmar
force-pushed
the
amitherman-1767
branch
from
68486ca
to
adb4789
Compare
|
Thanks, I fixed up the branch history and added tests for the changes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When Catch parses quoted test name, it may insert wrong positions of escape characters into
TestSpecParser::m_escapeChars, because the quotes are not added to the pattern itself
I added a simple data member to TestSpecParser that will track the right location of those characters in the pattern.
GitHub Issues
This PR resolves Issue #1767