Allow custom precision in error reports for floating-point numbers #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Apr 26, 2019
Codecov Report
@@ Coverage Diff @@
## master #1614 +/- ##
==========================================
- Coverage 81.1% 80.91% -0.19%
==========================================
Files 124 124
Lines 3476 3484 +8
==========================================
Hits 2819 2819
- Misses 657 665 +8 |
Codecov Report
@@ Coverage Diff @@
## master #1614 +/- ##
======================================
Coverage 81.1% 81.1%
======================================
Files 124 124
Lines 3476 3476
======================================
Hits 2819 2819
Misses 657 657 |
|
Thanks, I fixed up the test and added documentation. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Per #1612, this change allows the user to set custom precision on floating-point test messages. I did implement the unit test gestured at in the issue, but I'm not sure if you want it.
GitHub Issues
Closes #1612.